Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Cargo's platform-specific dependencies #239

Closed
wants to merge 1 commit into from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Oct 31, 2014

glfw-sys is now built only on i686-unknown-linux-gnu, x86_64_unknown_linux_gnu, i686-apple-darwin and x86_64-apple-darwin (all relevant platforms but windows).

In the long-term this should be changed again to use the new build commands system that has been accepted but is not yet implemented in Cargo.

Note: I didn't test if it works on Linux because platform-specific dependencies are not in the Cargo nightlies yet. I recommend quickly trying on OS/X too.

@brendanzab
Copy link
Member

Awesome! Could you also change the README?

@tomaka
Copy link
Contributor Author

tomaka commented Oct 31, 2014

I'm getting errors related to -fPIC when trying to build on Linux, but I don't see how this could be related to this PR.

@bvssvni
Copy link
Member

bvssvni commented Oct 31, 2014

@tomaka I had problems with -fPIC before, perhaps you find something useful #90

@brendanzab
Copy link
Member

cc. @cmr

@brendanzab
Copy link
Member

@metajack Can we update glfw to the latest development version? I think this might allow this to pass.

@bvssvni
Copy link
Member

bvssvni commented Dec 26, 2014

Is this PR outdated?

@tomaka
Copy link
Contributor Author

tomaka commented Dec 26, 2014

When I submitted this PR, we didn't have build scripts, gcc, pkgconfig, etc.
So yes it is outdated.

The best thing to do is probably to add a links = "glfw" entry in the glfw-sys package, and add in the README something similar to what I did for freetype-sys: https://github.com/PistonDevelopers/freetype-sys#for-windows-users

@tomaka tomaka closed this Dec 26, 2014
@tomaka tomaka deleted the update-cargo branch December 26, 2014 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants