Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MouseScroll event for LineDelta with correct formatting #66

Merged
merged 1 commit into from
Nov 10, 2015

Conversation

Nixes
Copy link
Contributor

@Nixes Nixes commented Oct 21, 2015

This fixes an issue on windows where the scoll event is not fired

This fixes an issue on windows where the scoll event is not fired
@mitchmindtree
Copy link
Contributor

Nice one, thanks :)

mitchmindtree added a commit that referenced this pull request Nov 10, 2015
Add MouseScroll event for LineDelta with correct formatting
@mitchmindtree mitchmindtree merged commit c30d880 into PistonDevelopers:master Nov 10, 2015
@mitchmindtree
Copy link
Contributor

Oh actually, I jumped the gun here. LineDelta gives very different values to the PixelDelta values. I'll leave this merged for now as a temporary fix until we handle this properly (probably by adding a LineDelta variant to the piston input crate.

@Nixes
Copy link
Contributor Author

Nixes commented Nov 10, 2015

Yeah there was some discussion on IRC originally, but I don't think windows even attempts to provide a pixel scroll value, and I think converting to a pixel scroll value will differ preferentially by application.

@mitchmindtree
Copy link
Contributor

Tracking issue at #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants