updating dependencies and changing nbt so that it builds. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Waiting for Travis CI before merging. @saml Do you want to be added as collaborator to PistonDevelopers? |
bvssvni
added a commit
that referenced
this pull request
Sep 26, 2014
updating dependencies and changing nbt so that it builds.
|
@bvssvni sure! |
| Compound(Compound) | ||
| NbtString(String), | ||
| List(ListT), | ||
| Compound(CompoundT) |
There was a problem hiding this comment.
Everything in this file is fine, except for the naming.
@bvssvni Please hold off merging until we can figure out better names. Maybe just Nbt{String,List,Compound} for the variants and keep the type aliases the way they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.