-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenGLWindow trait #45
Add OpenGLWindow trait #45
Conversation
@@ -25,3 +25,6 @@ git = "https://github.com/pistondevelopers/input" | |||
[dependencies.quack] | |||
git = "https://github.com/pistondevelopers/quack" | |||
#version = "0.0.13" | |||
|
|||
[dependencies] | |||
libc = "0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably use libc = "*"
like Gfx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just libc not updated on crates.io yet. In git already fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work with "0.1.4"? Or does it use "0.1.0"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I don't expect libc::c_void
to change, so adding libc = "*"
should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It the lower bound. >= 0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
Wait merging until libc has been updated on crates.io. |
Now rustc-serialize broken. |
rustc-serialize fixed, all is well. |
Nice! |
close #44