Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate language file #17

Open
ericsboro opened this issue Feb 27, 2021 · 16 comments
Open

separate language file #17

ericsboro opened this issue Feb 27, 2021 · 16 comments
Assignees
Labels
enhancement New feature or request

Comments

@ericsboro
Copy link

Hi,

Your project is really amazing! Would it be anyhow possible to add separate language file with switch somewhere in setting? I'm from Ukraine and translating all important tags manually after every release :)

If you like the idea — I'm ready to do translation DE-EN-UA and in future can help to maintain it :)

@Pittini Pittini self-assigned this Feb 28, 2021
@Pittini Pittini added the enhancement New feature or request label Feb 28, 2021
@Pittini Pittini assigned Pittini and unassigned Pittini Feb 28, 2021
@Pittini
Copy link
Owner

Pittini commented Feb 28, 2021

Hi, thanks for the interest. Its not so easy at it sounds, because a lot of Textdata also comes from the Adapter itself. So, i think its necesarry to involve also the HeatingControl Programmer @rg-engineering . If he sees a possibility to integratet different languages, then we can think about how.

@rg-engineering
Copy link
Contributor

@ericsboro you closed that issue while I started on adapter side. Do you still need that translation?

@ericsboro
Copy link
Author

@ericsboro you closed that issue while I started on adapter side. Do you still need that translation?

I thought you are not really interested in major adapter update, so I closed issue. But translation at least to english would really nice to have :)
If there’s anything I can do to help - I will be glad to participate :)

@ericsboro ericsboro reopened this Mar 15, 2021
@rg-engineering
Copy link
Contributor

I'll implement it in adapter first. then we need to find a solution for widgets here...

@ericsboro
Copy link
Author

Cool! Thanks a ton your your efforts :)

@rg-engineering
Copy link
Contributor

see my comment under rg-engineering/ioBroker.heatingcontrol#225 about new Datapoints

@rg-engineering
Copy link
Contributor

I used my translations in vis. (not finished everywhere, but almost)
I pushed 3.1.3 version here: https://github.com/rg-engineering/iobroker-heatingcontrol-vis
you also need 2.3.1 from adapter (available here https://github.com/rg-engineering/ioBroker.heatingcontrol)

@ericsboro if you like you can help to verify translations.

@ericsboro
Copy link
Author

guys, you are awesome :)

here's what i found not translated (with proposed translation to EN):

headers: Allgemeines (General), Uhrzeit (Clock), Wozi (Livingroom), Küche (Kitchen), Raumstatus (Room Status)
subtitles: Profil 1 (Profile 1)
in section "Times/week" -> Mo. to So. (Mo. to Su.)
in separate room info:
Screenshot 2021-03-30 at 11 49 21

@Pittini
Copy link
Owner

Pittini commented Mar 30, 2021

Most of still not translated texts are my part, but sorry, im very busy atm, ill do it if i found some time.

@ericsboro
Copy link
Author

@Pittini can i help with that?

@rg-engineering
Copy link
Contributor

rg-engineering commented Apr 2, 2021

I'll continue here...
I would not translate the room-dependent names, as these views have to be configured by the user himself (own data points, etc.) Here we add only templates which could be used by user, but in any case he needs to configure it to his own needs.

BTW @ericsboro : You can find all translations here:
https://github.com/rg-engineering/ioBroker.heatingcontrol/blob/master/lib/vis_words.js
If you like you can change it there and create PullRequest

rg-engineering added a commit to rg-engineering/iobroker-heatingcontrol-vis that referenced this issue Apr 2, 2021
rg-engineering added a commit to rg-engineering/ioBroker.heatingcontrol that referenced this issue Apr 2, 2021
rg-engineering added a commit to rg-engineering/ioBroker.heatingcontrol that referenced this issue Apr 2, 2021
@Pittini
Copy link
Owner

Pittini commented Apr 3, 2021

Working on it now. Found the following Issues:

  1. heatingcontrol.0.vis.translations.cardHzngMoFrSaSu.SaSu has Text: Sa. bis Su. - should be Sa. bis So.
  2. Missing translation for Infomsg Text: "Steuerelemente ausgeblendet, keine Absenkmethode gewählt." at heatingcontrol.0.vis.translations.cardHzngProfilParam
  3. Missing Translation for caption "Profilparam." at heatingcontrol.0.vis.translations.cardHzngProfilParam
  4. Missing Translation for caption "Allgemeines" at heatingcontrol.0.vis.translations.cardHzngGlobals
  5. Missing Translation for caption Raumstatus for cardHzngRooms
  6. Missing Translation for Navbar Text "Aktives Profil" and "Raum" for abar

@rg-engineering
Copy link
Contributor

see my comments:

  • heatingcontrol.0.vis.translations.cardHzngMoFrSaSu.SaSu has Text: Sa. bis Su. - should be Sa. bis So.
    -> will be available with next commit

  • Missing translation for Infomsg Text: "Steuerelemente ausgeblendet, keine Absenkmethode gewählt." at heatingcontrol.0.vis.translations.cardHzngProfilParam
    -> you'll find it under heatingcontrol.0.vis.translations.cardHzngProfilParam.HintNotEnabled

  • Missing Translation for caption "Profilparam." at heatingcontrol.0.vis.translations.cardHzngProfilParam
    -> will be available with next commit

  • Missing Translation for caption "Allgemeines" at heatingcontrol.0.vis.translations.cardHzngGlobals
    -> you'll find it under heatingcontrol.0.vis.translations.cardHzngGlobals.General

  • Missing Translation for caption Raumstatus for cardHzngRooms
    -> you'll find it under heatingcontrol.0.vis.translations.cardHzngRooms.RoomState

  • Missing Translation for Navbar Text "Aktives Profil" and "Raum" for abar
    -> you'll find it under heatingcontrol.0.vis.translations.tnav.ActiveProfile and heatingcontrol.0.vis.translations.tnav.Room

rg-engineering added a commit to rg-engineering/ioBroker.heatingcontrol that referenced this issue Apr 3, 2021
@Pittini
Copy link
Owner

Pittini commented Apr 4, 2021

Its done. Added copy Buttons also. See V-3.2.0

@Pittini
Copy link
Owner

Pittini commented Apr 5, 2021

@ericsboro Und wer übersetzt jetzt die readme/Installationsanweisung auf russisch? :)

@ericsboro
Copy link
Author

@Pittini i can check translation EN-RU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants