Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote groups column name #12

Merged
merged 1 commit into from Aug 4, 2021
Merged

Quote groups column name #12

merged 1 commit into from Aug 4, 2021

Conversation

erAck
Copy link
Contributor

@erAck erAck commented Aug 9, 2020

Since MySQL 8 groups is a reserved keyword, quote it in backticks
on every use.

@erAck
Quote groups column name
c31ccdd 
Since MySQL 8 groups is a reserved keyword, quote it in backticks
on every use.
@erAck erAck mentioned this pull request Feb 20, 2021
Closed
@erAck
Copy link
Contributor Author

erAck commented Aug 4, 2021

@plegall
Will this now that Piwigo/Piwigo@1ec5a29 removes the groups club from Piwigo be finally considered for a merge? Else this extension will break again.

@plegall plegall merged commit a629e25 into Piwigo:master Aug 4, 2021
@erAck erAck deleted the mysql-8-reserved-keywords branch August 5, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erAck @plegall