Remove laucher activity #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far the behavior differed depending on if it's the first user to login or if we added a 2nd account later on.
We actually should leave the user manager if the last account is removed, but not crashing is good too
it's just 2 functionss
|
the main motivation was your comment in the other PR and my inability to fix back button to go through the launcher again without dropping the animation. And without the animation, the launcher is pretty useless I figured. |
ramack
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The laucher activity adds quite some complexity for very little gain. It screws with the activity stack and the main activity can handle the case of no accounts just fine.