Mobile album photo view in 13.1.0 not working anymore due to syntax error in footer.tpl in smartpocket theme (with PHP 7.x)

[bigcookie]

Hello,

i updated to 13.1.0 recently, but the photo view inside an album is not working anymore. Thrown error in GUI:

Fatal error: Uncaught --> Smarty Compiler: Syntax error in template "file:/var/www/vhosts/xxxx/xxxx/themes/smartpocket/template/footer.tpl" on line 20 "document.cookie = 'screen_size='+jQuery(document).width()+'x'+jQuery(document).height()+';path={isset($COOKIE_PATH) ? $COOKIE_PATH : ''}';" - Unexpected " ? ", expected one of: "}" <-- thrown in /var/www/vhosts/xxxx/xxxxx/include/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php on line 20

Standard view works fine. Albums are still listed on mobile, but when opening an album, no photos are shown and the error is listed at the bottom of the page

[bigcookie]

[bigcookie]

[bigcookie]

I checked the footer template in
themes/smartpocket/template/footer.tpl
I changed the line 20 from:
document.cookie = 'screen_size='+jQuery(document).width()+'x'+jQuery(document).height()+';path={isset($COOKIE_PATH) ? $COOKIE_PATH : ''}';
to
document.cookie = 'screen_size='+jQuery(document).width()+'x'+jQuery(document).height()+';path={$COOKIE_PATH}';

So I reverted this commit Piwigo/piwigo-smartpocket@1e948e4 . The template error is gone and all photos are showing properly.
Unfortunately I dont know how the syntax should be in a corrected way, so I cannot fix it and commit :-(...

[bigcookie]

I tried this syntax:
document.cookie = 'screen_size='+jQuery(document).width()+'x'+jQuery(document).height()+';path={$COOKIE_PATH|default:''}';
Not sure if correct, if confirmed to be working for others, this would be a solution...

[erAck]

This part
+';path={isset($COOKIE_PATH) ? $COOKIE_PATH : ''}';
of course is wrong for the levels of single quotes forming string literals to assemble.
I'd guess it should instead be

+';path='{isset($COOKIE_PATH) ? $COOKIE_PATH : ''};

See also https://piwigo.org/forum/viewtopic.php?id=32263

[bigcookie]

Tested my patch (#1766 (comment)) also on PHP 8 - works so far. I created a PR
Piwigo/piwigo-smartpocket#8

[jamie-marchant]

Any work around in the meantime?

[erAck]

Sure, try the patch of the pull request mentioned and give feedback whether it works for you. Or try the change of my previous comment. One of them should work. Or replace that line with the old code as mentioned above in #1766 (comment) .

[dj2k]

The patch of the pull request works for me and my PHP 7.4.32.

[erAck]

+';path={$COOKIE_PATH|default:''}';

I'm not convinced of that approach, see my comment at the patch Piwigo/piwigo-smartpocket#8 (comment) .

[plegall]

@erAck @bigcookie have you tested the commit pushed by @MatthieuLP ? Piwigo/piwigo-smartpocket@738dcde

[erAck]

@plegall @MatthieuLP yes that works, thanks!

[jamie-marchant]

I don't have a phone with this problem but my friend says the site is now working for her.

[bigcookie]

@plegall the patch from @MatthieuLP works for me.
I agree, that I didnt understand to replace a missing string with an empty one. I just tried to fix the syntax error. The new patch looks better to me.
I will cancel my PR.