use HTTP_X_FORWARDED_PROTO when behind a proxy #1637
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When behind a proxy, absolute root url is construct using HTTP_X_FORWARDED_HOST but is ignoring the scheme.
The modification proposed is to use HTTP_X_FORWARDED_PROTO which include the scheme when construct the absolute root url.
Use case :
Piwigo is running in docker container which expose the service with HTTP. A traefik proxy is exposing the service via HTTPs. Without this modification, url are return with http:// scheme.
May resolve issue #1527