Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made format subdirectory (i.e. "pwg_format") configurable #929

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joeroe
Copy link

@joeroe joeroe commented Sep 27, 2018

Currently the multiple formats feature looks for formats in a hard-coded sub-directory, pwg_format, but it's not always desirable to organise files this way.

This change makes the name of the subdirectory a config variable (format_dir), defaulting to pwg_format to maintain backwards compatibility. It can be set to . to maintain a flat file structure.

@joeroe
Copy link
Author

joeroe commented Sep 27, 2018

Another small change for maintaining tidy file systems: ignoring unix-style hidden files, e.g. the many empty ._ files created by MacOS.

@plegall
Copy link
Member

plegall commented Oct 1, 2018

Hi @joeroe

Your code seems fine, but I would like to better understand why it's fine to have hard-coded pwg_representative and not pwg_format

@joeroe
Copy link
Author

joeroe commented Oct 1, 2018

Thank you for the quick response @plegall. The simple answer is that I don't use pwg_representative, only pwg_format, so I only looked at that. I think it would be nice for both to be configurable.

To explain a little: I'm using Piwigo as a friendly interface for a preexisting gallery of scientific images that are linked to other databases. Therefore I'm trying to avoid changing the directory structure or inserting application-specific files, as much as possible.

@joeroe
Copy link
Author

joeroe commented Sep 17, 2019

@plegall Is it possible to get an update on whether this will be merged into master? If not I would like to investigate making it a plugin, as each update is currently breaking my file structure.

@Arnie97
Copy link
Contributor

Arnie97 commented Nov 21, 2019

This looks promising. I'd like my raw images to be kept in the same directory as JPEGs - which is also the choice of many camera manufacturers. Any updates?

@joeroe
Copy link
Author

joeroe commented Aug 12, 2020

@plegall Sorry to be a bother, but any updates on this? The latest update has once again broken my formats. Would it help if I also made pwg_representative configurable and added it to the pull request?

@plegall
Copy link
Member

plegall commented Jul 23, 2022

Hi @joeroe

@plegall Would it help if I also made pwg_representative configurable and added it to the pull request?

Yes please, do the same for pwg_representative and I'll merge the pull-request.

Warning: with #389 we have added some occurences of pwg_format in core PHP code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants