Test addressing feedback #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sinks` parameter rapresents a list of supported sinks (currently only github and gchat). Its content, informs Cogito about selective sending of messages/statuses.
In the case of chat only sending, if there is no message file, the inputs dir is not mandatory anymore. It's still mandatory if there is a message file in the put parameters.
Since `sinks` can be configured optionally as Source or Put.Params, we need to validate user inputs.
- Increase coverage for processing input dirs, the possible cases are changed. - Standardize base parameter names following which Cogito feature is addressed. - Check Sinks() error also in cmds like `get` and `check` not only `put`.
If it is a chat only sending, there is no repo.
It gives better control at once to find where it could eventually updated without spreading these value across Cogito code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.