fix CI and various CI and test improvements #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marco-m-pix4d
commented
Jan 4, 2020
marco-m-pix4d
commented
- make the test repo public. I think that this is the main reason of the test failure. I think I made it private when I added it to tf.
- change the GitHub token
- better error diagnostic in tests
- simplify the tests for a read-only repository
- Separate dependencies download from test running. - Install the human-friendly gotestsum test runner (this will make it easier to differentiate CI builds that do not run the E2E tests).
marco-m-pix4d
requested review from
aledegano,
aliculPix4D,
kmdouglass,
manuel-cc,
muzaffar-omer,
odormond and
wagdav
as code owners
Merged
odormond
approved these changes
Jan 6, 2020
aledegano
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.