Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return outputSuffix. Add CCD-TEMP keyword into integrated file #50

Closed
wants to merge 1 commit into from

Conversation

oleg-milantiev
Copy link

Hi.

As discuss here https://pixinsight.com/forum/index.php?topic=11600.0 , add CCD-TEMP into integrated file. For example masterDark integration from few -20C darks:

IMAGETYP= 'Master Dark' / Type of image
CCD-TEMP= -20. / Averate ccd-temperature
....

Also Juan. You forgot to support other formats except xisf. I return outputSuffix and ability to fast change suffix in *general.js file. Please be so kind to think about fit-files user like me. I want to use your Greate PixInsight, but at work MUST to use FIT. Ok? :)

@jconejero
Copy link
Member

Hi Oleg,

Thank you for your push request.

You forgot to support other formats except xisf

No, I didn't forget to support other formats. The suppression of an output format selection feature in the BPP script has been intentional. XISF is, besides the native file format of the PixInsight platform, the only format able to support new features and functionalities that we'll implement in our image preprocessing tools and pipelines. The FITS format has been deprecated in PixInsight for the reasons (among others) described here:

http://pixinsight.com/xisf/

Since other formats such as TIFF, JPEG, etc. make no sense for preprocessing, providing a format selection feature in BPP (as well as in tools such as ImageCalibration, StarAlignment, etc) makes no sense and can only generate confusion and problems, especially in the medium-long term.

If you need FITS to support legacy applications, you can use the BatchFormatConversion script to convert from XISF to FITS very easily.

As for the average CCD-TEMP keyword, I agree this is a nice feature, so if you remove the 'return outputSuffix' part in a new push request, I'll work on integrating it in the official BPP version. I think we can implement this feature also in ImageIntegration, as an option.

@jconejero jconejero closed this Oct 9, 2017
@oleg-milantiev
Copy link
Author

:) Are u realy think drop FITs from product will improve it?
Many ppls like me using your program not from start to jpeg, but just one or another part. For me its calibrate, aligment and sometimes few post processings part. Should we import / export any time to xisf and vv? Oh, Juan-Juan... this (no-FITs) isolation and iPhone-way (father better know what children want) - not a good product rise direction :(

Realy think its normal to use BPP and batchConvert after as main workflow ? :)
When you would block batchConverter and other way to export FITs? :)

Or its just a joke?

p.s. found one bug. Fixed localy, wait your decision.

@jconejero
Copy link
Member

I never jest with my work, so no, this is no joke. As a side note, the "Oh, Juan-Juan" part of your post is really unnecessary.

We have not dropped FITS support, since PixInsight can still read and write FITS files without problems. As noted in my previous message, the FITS format has been deprecated in PixInsight, but you still can export large sets of FITS files very easily using the BatchFormatConversion script in just a few clicks. So there is no 'no-FITS isolation' and definitely no 'iPhone-way' thing, whatever that is intended to mean. We just have XISF, a new free, open, modern and efficient format, which is a big step forward IMHO. I am sorry if you don't like XISF and/or don't understand the reasons why we are pushing its development.

On the other hand, nothing stops you from customizing BPP as you want and use your modified version for your own purposes. However, don't expect your customizations, as you have submitted them in this push request, to be included in the official version. The outputSuffix parameter won't be reimplemented in the official version of BPP for the reasons I described in my previous comment.

@oleg-milantiev
Copy link
Author

Sure, nevermind.

Its your toy. Bye.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants