Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release archives hash changed #2511

Closed
michaelmigliore opened this issue Jun 28, 2023 · 9 comments
Closed

Release archives hash changed #2511

michaelmigliore opened this issue Jun 28, 2023 · 9 comments

Comments

@michaelmigliore
Copy link

Description of Issue

We are using VCPKG to install USD and it uses github direct download link internally, like this one:

https://github.com/PixarAnimationStudios/USD/archive/v23.05.tar.gz

For some reason, the sha512 hash of the downloaded have changed recently. It was fd3e7a90f837a5d016d94be34747b2c1daed3f01f252e4b1aa5cb195f32acaecca9373b8f5c7be9c235148f04b0afa47da9462b357ef1dd1e11cf20a7225ae66 before, and became 6669191c3497e244c958949b62a749958ab01e8e1edc7b3476d59c31395e147acf6f4ba7aae069c5ceab7fe2eb321e81e4e5f66beb72814be36e0fec98d3d034.

This was observed on different computers.

Have you changed anything in the repository configuration that could explain it? (e.g. inclusion of LFS files in the archive)

@spiffmon
Copy link
Member

spiffmon commented Jun 28, 2023 via email

@michaelmigliore
Copy link
Author

Probably yes since the root folder is now OpenUSD-23.05 instead of USD-23.05

@spiffmon
Copy link
Member

OK, so that's a one-time thing, at least. @michaelmigliore , thanks for referencing your vcpkg Issue... can you let us know when that gets executed so we can close this Issue?

@jesschimein
Copy link

Filed as internal issue #USD-8452

@LazyDodo
Copy link

This also hit us with the blender deps builder, officially released tar balls should never change, just to be sure, is this change permanent? That's ok, I just want to be sure we don't start a game of "what's the hash this week?"

@spiffmon
Copy link
Member

Yes, it is permanent and one-time (if indeed the cause is the repository getting renamed). We weren't aware of this potential fallout of renaming a gitHub repo... it might be good if GitHub added mention of it in their docs on renaming repos?

@michaelmigliore
Copy link
Author

I submitted a PR to fix VCPKG package, but all the previous versions are broken, so it will force VCPKG users to update to 23.5#3. It's not a big deal for us (as long as it happens once).
Feel free to close the issue when you want, it will be fixed in VCPKG soon but that's not a VCPKG-only problem, and I don't think there's anything you can do anyway.

@LazyDodo
Copy link

Fixed the issue on our end as well. As for prevention in the future, other projects generally upload an actual tar.gz/zip file for the source, rather than relying on github not to change anything down the road in their automated system. An example of this would be OpenImageDenoise's releases.

@spiffmon
Copy link
Member

Thanks, @michaelmigliore and @LazyDodo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants