hdUsdWriter plugin - Render to text delegate #3003
Conversation
|
Filed as internal issue #USD-9460 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| const auto& attr = prim.CreateAttribute(UsdGeomTokens->clippingPlanes, SdfValueTypeNames->Float4Array, | ||
| false /*custom*/, SdfVariabilityVarying); |
There was a problem hiding this comment.
| const auto& attr = prim.CreateAttribute(UsdGeomTokens->clippingPlanes, SdfValueTypeNames->Float4Array, | |
| false /*custom*/, SdfVariabilityVarying); | |
| const auto& attr = camera.CreateClippingPlanesAttr(); |
| const auto& propertySpec = schemaDefinition->GetSchemaPropertySpec(param); | ||
| auto attr = prim.CreateAttribute(param, propertySpec->GetTypeName(), false, propertySpec->GetVariability()); |
There was a problem hiding this comment.
| const auto& propertySpec = schemaDefinition->GetSchemaPropertySpec(param); | |
| auto attr = prim.CreateAttribute(param, propertySpec->GetTypeName(), false, propertySpec->GetVariability()); | |
| const auto& attributeDef = schemaDefinition->GetAttributeDefinition(param); | |
| auto attr = prim.CreateAttribute(param, attributeDef->GetTypeName(), false, attributeDef->GetVariability()); |
| PrimvarMap::accessor pvAccessor; | ||
| if (_primvars.find(pvAccessor, name) && pvAccessor->second.value.IsHolding<T>()) | ||
| { | ||
| f(pvAccessor->second.value.template UncheckedGet<T>()); |
There was a problem hiding this comment.
| f(pvAccessor->second.value.template UncheckedGet<T>()); | |
| f(pvAccessor->second.value.UncheckedGet<T>()); |
| // incorrect, std::string instead of TfToken. | ||
| // TfToken parameters might come through as std::string, so we need to do some extra | ||
| // conversions. | ||
| if (inputType == SdfValueTypeNames->Token && !parameter.second.template IsHolding<TfToken>()) |
There was a problem hiding this comment.
| if (inputType == SdfValueTypeNames->Token && !parameter.second.template IsHolding<TfToken>()) | |
| if (inputType == SdfValueTypeNames->Token && !parameter.second.IsHolding<TfToken>()) |
| // conversions. | ||
| if (inputType == SdfValueTypeNames->Token && !parameter.second.template IsHolding<TfToken>()) | ||
| { | ||
| if (parameter.second.template IsHolding<std::string>()) |
There was a problem hiding this comment.
| if (parameter.second.template IsHolding<std::string>()) | |
| if (parameter.second.IsHolding<std::string>()) |
| const auto& token = parameter.second.template UncheckedGet<TfToken>(); | ||
| input.Set(SdfAssetPath{ token.GetString(), token.GetString() }); | ||
| } | ||
| else if (parameter.second.template IsHolding<std::string>()) |
There was a problem hiding this comment.
| else if (parameter.second.template IsHolding<std::string>()) | |
| else if (parameter.second.IsHolding<std::string>()) |
| } | ||
| else if (parameter.second.template IsHolding<std::string>()) | ||
| { | ||
| const auto& string = parameter.second.template UncheckedGet<std::string>(); |
There was a problem hiding this comment.
| const auto& string = parameter.second.template UncheckedGet<std::string>(); | |
| const auto& string = parameter.second.UncheckedGet<std::string>(); |
| /*! | ||
| \page hdUsdWriter HdUsdWriterRenderDelegate : Renderer plugin. | ||
|
|
||
| \section hdUsdWriter_overview Usd Writer Render Delegate |
There was a problem hiding this comment.
Not a blocker, but it would be wonderful to have more documentation here, e.g. of example invocation of hdcapture and example output or something. Also, possibly the HdTiny comment is extraneous?
| light | ||
| material | ||
| mesh | ||
| openvdbasset |
There was a problem hiding this comment.
We had some questions internally about whether we need to guard openvdbasset if we don't compile against openvdb; not sure if you know offhand. My memory is the only place we actually invoke OpenVDB is in the render delegate, which makes me think this is ok.
|
|
||
| PYMODULE_FILES | ||
| fuzzytextdiff.py | ||
| hdusdwriterdriver.py |
There was a problem hiding this comment.
We've had requests even before this has landed to (1) move this to pxr/usdImaging/usdAppUtils; and (2) rewrite it in C++ :). Are you all up for doing that? It's not a ton of code. It would probably mean you'd need to get rid of the fuzzytextdiff reference from the driver, and move fuzzytextdiff and the compare() function to pxr/usdImaging/bin/hdcapture directly.
Description of Change(s)
This PR adds a new plugin,
hdUsdWriterand tools for creating tests or debugging render output. The plugin provides a render delegate that stores information it receives from Hydra and serializes it (the included tooling is for text diffing and outputs usda).The library includes a python module that utilizes the driver to perform fuzzy text diffing between the output and an expected result. A new tool called
hdCaptureprovides a simple way to exercise this functionality.The delegate supports most prim types, and is easily extendable by downstream projects.
Fixes Issue(s)