Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that command wrapping only runs on Windows #3056

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nvmkuruc
Copy link
Contributor

@nvmkuruc nvmkuruc commented Apr 24, 2024

Description of Change(s)

The shebang.py script has two modes, one which does substitution of \pxrpythonsubst, the other which generates a wrapper command for Windows. The mode is argument dependent. However, if cmake fails to set PXR_PYTHON_SHEBANG, the wrong mode can get executed and a build with errors will silently be installed.

This change separates the unrelated windows only components out of shebang.py into a sibling winpycmd.py script. It also adds a warning to winpycmd to alert users that it's being run on a non-Windows platform.

With this fix, the build will now fail (instead of silently installing a build with errors) when PXR_PYTHON_SHEBANG cannot be correctly set.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link

Filed as internal issue #USD-9591

@jesschimein
Copy link

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants