Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update player event names #352

Merged
merged 9 commits into from
Jul 9, 2023
Merged

Update player event names #352

merged 9 commits into from
Jul 9, 2023

Conversation

mcpsbot
Copy link
Contributor

@mcpsbot mcpsbot commented Jul 8, 2023

No description provided.

@mcpsbot mcpsbot added Meta: BugFix PRs that fix bugs or issues. Status: Needs Testing PRs that need testing from the author or volunteers. Status: WIP Issues and PRs that are still a work in progress. labels Jul 8, 2023
@mcpsbot mcpsbot self-assigned this Jul 8, 2023
@mcpsbot mcpsbot marked this pull request as ready for review July 8, 2023 20:56
@mcpsbot mcpsbot requested a review from JaronZ as a code owner July 8, 2023 20:56
@mcpsbot
Copy link
Contributor Author

mcpsbot commented Jul 8, 2023

@JaronZ any Thoughts

JaronZ
JaronZ requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@JaronZ JaronZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change tracksAdd.ts?

src/listeners/player/channelEmpty.ts Outdated Show resolved Hide resolved
src/listeners/player/trackAdd.ts Outdated Show resolved Hide resolved
mcpsbot and others added 3 commits July 9, 2023 15:45
@mcpsbot @JaronZ
Update src/listeners/player/channelEmpty.ts
97e2985 
Co-authored-by: Jaron <60853956+JaronZ@users.noreply.github.com>
@mcpsbot @JaronZ
Update src/listeners/player/trackAdd.ts
86e0165 
Co-authored-by: Jaron <60853956+JaronZ@users.noreply.github.com>
@mcpsbot
Update tracksAdd.ts
96ed53f
@mcpsbot mcpsbot requested a review from JaronZ July 9, 2023 14:58
@mcpsbot mcpsbot added this to the Bugs milestone Jul 9, 2023
@JaronZ JaronZ changed the title Update channelEmpty.ts Update player event names Jul 9, 2023
@mcpsbot
Copy link
Contributor Author

mcpsbot commented Jul 9, 2023

Could you put your ts error fix into this push

@mcpsbot mcpsbot added Semver: Patch PRs that contain bugfixes and should be released in the next patch version. Bug: Fixed Issues that report bugs and have been fixed. Status: Ready To Merge PRs that are ready to merge. Status: Review Ready PRs that are ready for author review. and removed Status: Needs Testing PRs that need testing from the author or volunteers. Status: WIP Issues and PRs that are still a work in progress. labels Jul 9, 2023
@JaronZ JaronZ merged commit bce46ad into renovate/fix/major-discord-player-dependency Jul 9, 2023
3 of 4 checks passed
@JaronZ JaronZ deleted the Fix-for-Player branch July 20, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaronZ JaronZ JaronZ approved these changes

Assignees

@mcpsbot mcpsbot

Labels
Bug: Fixed Issues that report bugs and have been fixed. Meta: BugFix PRs that fix bugs or issues. Semver: Patch PRs that contain bugfixes and should be released in the next patch version. Status: Ready To Merge PRs that are ready to merge. Status: Review Ready PRs that are ready for author review.
Projects
No open projects
OurTube
Status: Done
Milestone
Bugs
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcpsbot @JaronZ