Optimizations to fix #268 & #267.

PixelVision8 · May 19, 2020 · 9e148f7 · 9e148f7
1 parent 5c6b3f4
commit 9e148f7
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 17 deletions.
diff --git a/Disks/PixelVisionOS/System/Tools/ColorTool/saves.json b/Disks/PixelVisionOS/System/Tools/ColorTool/saves.json
@@ -3,13 +3,13 @@
     "GameChip":
     {
         "savedData":{
-            "selectedSprite": "-1",
-            "selectedPalette": "-1",
-            "selectedColor": "-1",
-            "rootDirectory": "/Workspace/SpaceRanger/",
-            "sessionID": "202005060916591670",
+            "selectedPalettePage": "0",
             "selectedSpritePage": "1",
-            "selectedPalettePage": "1"
+            "sessionID": "202005182033044056",
+            "rootDirectory": "/Workspace/Spirally-Spiral/",
+            "selectedColor": "-1",
+            "selectedPalette": "-1",
+            "selectedSprite": "-1"
         }
     }
 }
diff --git a/Disks/PixelVisionOS/System/Tools/FontTool/saves.json b/Disks/PixelVisionOS/System/Tools/FontTool/saves.json
@@ -3,8 +3,8 @@
     "GameChip":
     {
         "savedData":{
-            "rootDirectory": "/Workspace/NewProjectB/",
-            "sessionID": "202005040753365042"
+            "sessionID": "202005182033044056",
+            "rootDirectory": "/Workspace/Spirally-Spiral/"
         }
     }
 }
diff --git a/Disks/PixelVisionOS/System/Tools/WorkspaceTool/saves.json b/Disks/PixelVisionOS/System/Tools/WorkspaceTool/saves.json
@@ -3,10 +3,10 @@
     "GameChip":
     {
         "savedData":{
-            "lastPath": "/Workspace/DragonSweeper/",
-            "selection": "9",
+            "sessionID": "202005182033044056",
             "scrollPos": "0",
-            "sessionID": "202005080627277948"
+            "selection": "0",
+            "lastPath": "/Workspace/Spirally-Spiral/"
         }
     }
 }
diff --git a/SDK/Engine/Chips/Graphics/DisplayChip.cs b/SDK/Engine/Chips/Graphics/DisplayChip.cs
@@ -240,6 +240,8 @@ public DrawRequest NextDrawRequest()
             // int colorID;
             // // int i;
             // int index;
+            var tmpWidth = Width;
+            var tmpHeight = Height;
 
             _total = width * height;
 
@@ -263,14 +265,12 @@ public DrawRequest NextDrawRequest()
 
                     // Make sure x & y are wrapped around the display
                     // Note: + size and the second modulo operation are required to get wrapped values between 0 and +size
-                    var size = this.Height;
-                    _srcY = (_srcY % size + size) % size;
-                    size = this.Width;
-                    _srcX = (_srcX % size + size) % size;
+                    _srcY = (_srcY % tmpHeight + tmpHeight) % tmpHeight;
+                    _srcX = (_srcX % tmpWidth + tmpWidth) % tmpWidth;
                     // size is still == _width from the previous operation - let's reuse the local
 
                     // Find the index
-                    _index = _srcX + size * _srcY;
+                    _index = _srcX + tmpWidth * _srcY;
 
                     // Set the pixel
                     Pixels[_index] = cachedColors[_colorID];

diff --git a/SDK/Runner/Services/WorkspaceService.cs b/SDK/Runner/Services/WorkspaceService.cs
@@ -329,8 +329,11 @@ public virtual void UpdateLog(string logString, LogType type = LogType.Log, stri
 
         public void SaveLog()
         {
-            if(LogInvalidated)
+            if (LogInvalidated)
+            {
                 SaveTextToFile(logFilePath, logService.ReadLog(), true);
+                LogInvalidated = false;
+            }
         }
 
         public void ClearLog()