Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon aliases #42

Merged
merged 1 commit into from Sep 9, 2021
Merged

Add icon aliases #42

merged 1 commit into from Sep 9, 2021

Conversation

natewiebe13
Copy link
Collaborator

Add icon aliases. This allows setting an alias for an icon you'd like to use. Closes #29

This allows adding aliases to the icon manager to ask for an icon for a particular context, rather than by the name of the icon itself. One example of when I would use this is for using the x icon. If I did want to update it, trying to find x in a codebase would be much more difficult than something like close or close-dialog.

@natewiebe13 natewiebe13 added this to the v2 milestone Sep 7, 2021
@natewiebe13 natewiebe13 self-assigned this Sep 7, 2021
@natewiebe13 natewiebe13 assigned Pixelrobin and unassigned natewiebe13 Sep 7, 2021
@natewiebe13 natewiebe13 merged commit 910e0d7 into v2.0 Sep 9, 2021
@natewiebe13 natewiebe13 deleted the icon-aliases branch September 9, 2021 20:51
@natewiebe13
Copy link
Collaborator Author

@Pixelrobin Merging, feel free to review post-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Aliases
2 participants