Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: thumbnail #329

Merged
merged 16 commits into from
Nov 1, 2023
Merged

Fix: thumbnail #329

merged 16 commits into from
Nov 1, 2023

Conversation

Poker-sang
Copy link
Collaborator

@Poker-sang Poker-sang commented Jul 12, 2023 •
edited

优化

  • IllustrationViewModel引用计数，减少内存占用
  • 简化代码逻辑通过SelectionIndex绑定更清晰
  • 修复Grid模式下自动不加载缩略图问题
  • 使用Binding+ConverterParameter={StaticResource ...}实现解耦
  • 缩略图引用计数
  • 漫画换页时应用新的图片大小，而不是与第一张一样（fixed in Misc #336）
  • 解决AdvancedCollectionView复用问题
  • 换页时，评论、画作信息等也更换
  • 用CardControl分割评论
  • 修复之前设置页的小bug
  • 一键全选时显示复选框
  • 窗口图标和标题
  • 加载图片加入Shimmer
  • 动图逻辑重写，不再使用GIF

预览

image
image
image

@Poker-sang Poker-sang changed the title 简化选择操作 Fix: thumbnail Jul 12, 2023
@Poker-sang Poker-sang marked this pull request as ready for review July 15, 2023 19:24
@dylech30th dylech30th merged commit 6baf5d7 into main Nov 1, 2023
7 checks passed
@Poker-sang Poker-sang deleted the Poker/fix/thumbnail branch November 4, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylech30th dylech30th dylech30th approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Poker-sang @dylech30th