Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add russian localy #358

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Add russian localy #358

merged 11 commits into from
Mar 7, 2024

Conversation

bropines
Copy link
Contributor

@bropines bropines commented Mar 7, 2024

Add Ru readme and ru localy (only in the language files, in the code I can't help you add).

@bropines
Copy link
Contributor Author

bropines commented Mar 7, 2024

As a default font for Russian I suggest to put the system Segoe UI.

@Poker-sang
Copy link
Collaborator

Thanks for the reminder, I hadn't thought about fonts before.

@Poker-sang Poker-sang linked an issue Mar 7, 2024 that may be closed by this pull request
@Poker-sang
Copy link
Collaborator

lgtm

@Poker-sang Poker-sang merged commit e725a8a into Pixeval:main Mar 7, 2024
3 checks passed
@Poker-sang
Copy link
Collaborator

I wrote a simple app that can figure out the missing resources. I hope it could help.

image

@bropines
Copy link
Contributor Author

bropines commented Mar 8, 2024

Convenient, can I somehow get/run it? In general, it would not be bad to add there the creation and editing of existing languages ​​based on other languages ​​(for example, I was translating from Chinese 😊).

@Poker-sang
Copy link
Collaborator

Poker-sang commented Mar 8, 2024

Edit existing language? Maybe I'll implement it later.
You can find its source code in https://github.com/Pixeval/ResourceChecker

Or you can run the published one:

@bropines
Copy link
Contributor Author

bropines commented Mar 8, 2024

By the way, the resource links were lost in translation
<PRIResource Include="Strings\ru-ru\EntryContainer.resjson" />
And I've added the translation of the function locally for now:
<PRIResource Include="Strings\ru-ru\CheckExitedContentDialog.resjson" />
When you're going to release a new version, tag me here (I'm subscribed to notifications and I'll update everything within a couple hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Translation feauture
2 participants