Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loading when using fill tool #580

Closed
Equbuxu opened this issue Oct 26, 2023 · 0 comments · Fixed by #583
Closed

Infinite loading when using fill tool #580

Equbuxu opened this issue Oct 26, 2023 · 0 comments · Fixed by #583
Labels
bug Something isn't working

Comments

@Equbuxu
Copy link
Member

Equbuxu commented Oct 26, 2023

  1. Create a 2048 x 2048 canvas
  2. Fill it with some solid color
  3. Choose a different color and set it's opacity to 0
  4. Spam click the canvas
fpFIfv9GgH.mp4
@Equbuxu Equbuxu added the bug Something isn't working label Oct 26, 2023
Equbuxu added a commit that referenced this issue Dec 2, 2023
@Equbuxu
Fix infinite floodfill loop when filling with transparent color (fix #…
56ef83b 
…580). This is not the ideal fix since floodfill should eventually support the 'overwrite' mode, but for now it doesn't support it anyway
@Equbuxu Equbuxu linked a pull request Dec 2, 2023 that will close this issue
Fixes #583
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes PixiEditor/PixiEditor
1 participant
@Equbuxu