Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sizeinput empty bug and aspect ratio infinite loop #107

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

flabbet
Copy link
Member

@flabbet flabbet commented Dec 17, 2020

Fixed #106 aspect ratio bug, which caused StackOverflow with some values.
Also fixed the Behavior which is used in SizeInput to convert numbers to Num px format, when focusing out without changing anything + now it supports "{num}px" format, ex. "15px".

@flabbet flabbet added the bug Something isn't working label Dec 17, 2020
@flabbet flabbet requested a review from CPKreu December 17, 2020 12:43
@flabbet
Copy link
Member Author

flabbet commented Dec 17, 2020

@CPKreuz and @Equbuxu review please :)

Copy link
Member

@CPKreu CPKreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Equbuxu
Copy link
Member

Equbuxu commented Dec 18, 2020

Yeah, seems to work fine now

@flabbet flabbet merged commit 0ee160b into master Dec 18, 2020
@flabbet flabbet deleted the aspectratio-bug branch December 18, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when trying to resize the canvas
3 participants