Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #379

Merged
merged 20 commits into from
Mar 8, 2022
Merged

Improvements #379

merged 20 commits into from
Mar 8, 2022

Conversation

flabbet
Copy link
Member

@flabbet flabbet commented Feb 28, 2022

cached recovered documents, changed wording and fixed shared toolbar setting once again

  • Round opacity
  • Pasting an image clears selection but undoing doesn't restore it
  • Merging layers doesn't register as a change (no asterisk next to filename)
  • Using the scroll wheel on the opacity field changes the text but not the opacity
  • Quick usage doesn't work for pipette #384
  • Alt color picker
  • Viewport and shortcuts focus fixes

@flabbet flabbet requested a review from CPKreu February 28, 2022 19:16
@CPKreu
Copy link
Member

CPKreu commented Feb 28, 2022

Didn't fix #357 for me, maybe we should add an popup displaying errors when recovering documents
And maybe wording might be recoverable in crash dialog would be better

@flabbet flabbet changed the title Fixed restoring documents Improvements Feb 28, 2022
@flabbet flabbet requested a review from Equbuxu March 2, 2022 19:20
Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The collapse button of the reference layer is still focusable, the same goes for:
    • The swap colors button inside of the color picker, not sure if this can be fixed without
      changing the color picker.
    • HEX/RGBA and background buttons of the navigator window
    • The close layer button
    • The pen mode button
  • Layer opacity undo breaks after using the scroll wheel (actually maybe in general too)
    1. Make a new document
    2. Scroll down above the opacity field
    3. Hold down undo
    4. It cycles between two values instead of going back up to 100
  • Pasting an image does strange things when the image is bigger than the canvas
    1. Copy a 64x64 image
    2. Paste it on a 16x16 canvas
    3. The image gets cropped and now you've got a big highlight
  • Exception when loading recovered files even though the files aren't corrupted
    1. Download crash-2022-03-04_02-39-31_420.zip
    2. PixiEditor Project Properties -> Debug -> General -> Open debug launch profiles UI -> Command line arguments -> Set to -- crash "pathtofile"
    3. Launch and recover files to see an exception (ViewModelMain.Current is null)
  • PixiEditor fails to load recovered files even though they were successfully saved #357 still isn't fixed, but I fixed it in Changed stream reading to always read all bytes PixiParser#14. Once it is merged we'll need to update the package

@flabbet flabbet requested a review from Equbuxu March 7, 2022 17:26
@flabbet
Copy link
Member Author

flabbet commented Mar 7, 2022

I didn't fix Exception when loading recovered files even though the files aren't corrupted. Also focus on ColorPicker is still there. It can be done probably using ControlTemplate. But I left it for now

@flabbet flabbet mentioned this pull request Mar 7, 2022
Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The close *tab* button (I've called it the "close layer button" by mistake last time) is still focusable.
  • I'd argue that the fix to Preserve aspect ratio doesn't work like it supposed to  #337 also broke the preserve aspect ratio function in the resize image/canvas dialogs, cause there I would expect them to always use the canvas proportions, not the stuff you've typed

Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found another case where undoing pasting doesn't bring selection back but I decided to make it into an issue (#394). I've also made an issue for recovering files after crash (#393). I think we should merge this PR and make a dev release

@flabbet flabbet merged commit 848957c into master Mar 8, 2022
@flabbet flabbet deleted the crash-report-fixes branch March 8, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick usage doesn't work for pipette
3 participants