Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixiThumbnailProvider 0.9 done in native mode #469

Merged
merged 1 commit into from
May 31, 2023

Conversation

tomaszkot
Copy link
Contributor

This is a native implementation of Thumbnail Provider based on the pixi preview data from a file's header.

To test it run a InstallPixiThumbnailProviderServer.bat file at PixiThumbnailProvider.

TODO: add an icon of the app in the lower right corner.

@Equbuxu
Copy link
Member

Equbuxu commented Feb 21, 2023

Wow, that was quick! I'll have to review it today, the PR might just make it into the 1.0 release

@tomaszkot
Copy link
Contributor Author

Theoretically it was very simple, but I had a trouble with interpreting array of bytes describing preview size. In .net there is BitConverter, in c++ you have to write it. It's working, though not supporting that big-endian and little-endian checks, so currently it will not work on Power PC. I can improve it of you support such architecture.

Today I'll try to add that app's icon in the corner of the thumbnail.

Copy link
Member

@Equbuxu Equbuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, for me the thumbnails already have the pixieditor logo in the corner (might be a win 11 thing?)

@flabbet
Copy link
Member

flabbet commented Feb 22, 2023

I'm gonna do a proper review in a few days, I don't want to risk releasing it to 1.0, it's too little time to test it properly

@tomaszkot
Copy link
Contributor Author

...for me the thumbnails already have the pixieditor logo in the corner (might be a win 11 thing?)

Wow, I do not have win11 so can not tell, doing it is possible, yet again not a piece of cake as loading pixi logo from rc file in c++ would be a nasty piece of code.

@tomaszkot
Copy link
Contributor Author

I'm gonna do a proper review in a few days, I don't want to risk releasing it to 1.0, it's too little time to test it properly

Yes, test it carefully as it's quite dangerous code (native + windows API handler). So test it on all OS supported by the app.
Also installer is to be changed to support it, so quite a change.

@Equbuxu Equbuxu changed the base branch from master to thumbnail-provider-integration May 31, 2023 03:56
@Equbuxu Equbuxu merged commit fa38cc3 into PixiEditor:thumbnail-provider-integration May 31, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants