Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the react-swipy implementation with something smoother #24

Open
Pjaerr opened this issue Jun 4, 2019 · 1 comment
Open

Replace the react-swipy implementation with something smoother #24

Pjaerr opened this issue Jun 4, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers improvement Not important, but could be fixed if time allows.

Comments

@Pjaerr
Copy link
Owner

Pjaerr commented Jun 4, 2019

I have noticed that using the react-swipy library for the card swiping can result in jankiness when swiping fast on mobile. This could potentially be replaced with something that is smoother.

The implementation is done within /frontend/src/components/CardContainer/CardContainer.js
@Pjaerr Pjaerr added enhancement New feature or request good first issue Good for newcomers improvement Not important, but could be fixed if time allows. labels Jun 4, 2019
@Pjaerr
Copy link
Owner Author

Pjaerr commented Jun 4, 2019

Upon testing, it seems that the implementation is smooth on the first use, but if you go back and switch to another category it gets progressively slower. This may be due to not cleaning up the Swipeable component.

See #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers improvement Not important, but could be fixed if time allows.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pjaerr