Rebuild/seperate backend and frontend #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 30, 2019 07:36
Moving the backend away from next.js and ssr, using the express backend as purely an API which the frontend will hit and get the exact data it needs in response, will be moving all logic not related to view into the backend, still in progress
In the service there are no catch statements so if anything fails it will fall back to the catch in the controller, this also happens, in the case of getPlaceData service where the request doesn't _fail_ but it returns an invalid status code, in this case we throw the error ourselves. In the controller this is then caught in the catch block and passed into the express next() function which, by default, will send this to the client, to make it more readable we prepend the error returned with a predefined error message that is imported in the controller it will be used. In this case it is an apiGetRequestFailed error.
They both have their own package.json and node modules but the backend has the .env file etc2
Moved all logic for transforming data returned by foursquare onto the serverside so that the frontend only cares about displaying what it is given. Also added cors to the backend restricting the origins"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.