Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] implement an ActionManager #49

Closed
3 of 4 tasks
Tracked by #41
NekroDarkmoon opened this issue Feb 18, 2023 · 0 comments
Closed
3 of 4 tasks
Tracked by #41

[Feat] implement an ActionManager #49

NekroDarkmoon opened this issue Feb 18, 2023 · 0 comments
Assignees
Labels
type: enhancement Refactor or improvement
Milestone

Comments

@NekroDarkmoon
Copy link
Collaborator

NekroDarkmoon commented Feb 18, 2023

Add a getter on the Item Document get actions () that returns an ActionManager class. This should be the default interface for interacting with actions on an item.

  • Add a proxy to the ActionManager that allows for direct access to actions. actionManager.itemId
  • Move all the action helpers from the base item class to the action manager.
  • Allow for the ActionManager instance to be iterable. Object.entries(actionManager) or actionManager.
  • [Feat] Add warning for actions system #59

Future improvements include sub managers for each action to easily get prompt data, Target data, roll data, and Consumers.

@NekroDarkmoon NekroDarkmoon added the type: enhancement Refactor or improvement label Feb 18, 2023
@NekroDarkmoon NekroDarkmoon added this to the 0.9.0 milestone Feb 18, 2023
@NekroDarkmoon NekroDarkmoon self-assigned this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Refactor or improvement
Projects
None yet
Development

No branches or pull requests

1 participant