fixed an error when the schema type is string
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schema": {
"type": "string",
"format": "url"
},
The previous code was trying to make a `JSON.parse` on a string
jeremy-carbonne
changed the title
stringstring
|
@jeremy-carbonne thanks for the contribution! i've just added a few minor changes on top of your fix. If you're happy with it then i'm keen to merge this in. |
|
I tested with the last changes, it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to use schema of type
object,array,numberandstring(filenot supported)https://swagger.io/docs/specification/2-0/describing-responses/
related #2