Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and helm fix #33

Merged
merged 6 commits into from Apr 18, 2020
Merged

Docs and helm fix #33

merged 6 commits into from Apr 18, 2020

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Apr 16, 2020

A couple of super minor things.

Docs:

  • I got bit by scope: "" in the docs for oidc, and had to dig in code/error messages to realize issuer was the url, and redirect url could be anything

Helm charts:

  • Service - I use external-dns annotations to let my loadbalancer ips define a hostname, so added support for annotations
  • Service - Added support for service externalTrafficPolicy - service.spec.externalTrafficPolicy - denotes if this Service desires to route external traffic to node-local or cluster-wide endpoints. There are two available options: Cluster (default) and Local. Cluster obscures the client source IP and may cause a second hop to another node, but should have good overall load-spreading. Local preserves the client source IP and avoids a second hop for LoadBalancer and NodePort type services, but risks potentially imbalanced traffic spreading.
  • Ingress needs to point at the container port (8000) not the service port (80)
  • Made the config map changes restart the deployment (checksum annotation suggested by helm)
  • Made the configmap have the entire config section. I'm pretty sure i didn't break anything since only including wireguard is one level too deep and keys won't match up.

Copy link
Owner

@Place1 Place1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the changes here. I'll try to get this merged over the weekend and added to the 0.2.0-rc release.

deploy/helm/wg-access-server/templates/ingress.yaml Outdated Show resolved Hide resolved
@Place1
Copy link
Owner

Place1 commented Apr 18, 2020

Thanks again for the PR. I'll get this up as an RC soon

@Place1 Place1 merged commit d53daca into Place1:master Apr 18, 2020
DasSkelett referenced this pull request in DasSkelett/wg-access-server Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants