Enable setting different service type for web interface and using existing PVC for persistence. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable using existing pvc for persistence.
|
Hey @nqngo, thanks for the PR. I actually didn't add support for using a loadbalanced service for the web service because wg access server is an http server without TLS. Exposing it via a loadbalancer is not a secure option for general users where a loadbalancer is typically routing a public IP. Would you be ok adding a note of this in the chart README? I don't really want to support TLS in wg-access-server directly because I believe most users will be making use of a TLS terminating ingress controller or other existing reverse-proxy infra that they have. |
Add comment on security implication of using LoadBalancer for web server.
|
Pretty sensible. I updated the README with the comment. |
|
@nqngo cheers for the contribution! i've released this as 0.2.3 You should be able to pull the updated chart now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using wg-access-server with MetalLB-BGP. Currently, the web interface service type is only ClusterIP. This change enables setting the web service type
LoadBalancer.In addition, the change also enables using an existing claim for persistence instead of creating it on deployment time.