Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action supporting build multi-arch images #73

Merged
merged 2 commits into from Oct 11, 2020
Merged

Github action supporting build multi-arch images #73

merged 2 commits into from Oct 11, 2020

Conversation

timtorChen
Copy link
Contributor

@timtorChen timtorChen commented Oct 10, 2020

This PR is for github action supporting auto build multi-arch images (issue #65).

The build will be triggered while

  1. you push a commit on master branch
  2. you push a tag on a commit

As the result, there will be three kind of image tag, the semver tag like 0.2.5, the latest tag refering the newest semver, and the edge tag refering top most commit on master branch.

Note that

Before merging, please add secrets DOCKER_USERNAME and DOCKER_TOKEN to the project secrets, enabling login into docker hub.

@timtorChen timtorChen changed the title Gh action Github action supporting build multi-arch images Oct 10, 2020
@Place1
Copy link
Owner

Place1 commented Oct 11, 2020

Hey, thanks for this PR. This is really great!

If you don't mind i'll merge this and then change it a little bit.

I'd like to change the following:

  • rename the edge tag to master so that it's the same name as the gh branch it tracks
  • change the tag wildcard to v*.*.* to hopefully catch any mistakes :)
  • update the moby/buildkit image to v0.8-beta

@Place1 Place1 merged commit 2ce996a into Place1:master Oct 11, 2020
@timtorChen timtorChen deleted the gh-action branch October 11, 2020 14:14
@timtorChen
Copy link
Contributor Author

Glad to help this project, and just a reminder, tag as v*.*.* will break the tagging convention you previously use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants