Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Mqtt integration #29

Merged
merged 35 commits into from
May 28, 2021
Merged

Mqtt integration #29

merged 35 commits into from
May 28, 2021

Conversation

mghill
Copy link
Contributor

@mghill mghill commented Dec 7, 2020

Implementation of #16

Could be enriched with images, but not strongly dependent on it.

@mghill mghill self-assigned this Dec 7, 2020
Copy link
Contributor

@kimburgess kimburgess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely notes on semantic and structural elements. Will review content separately.

Analytics-API/MQTT.md Outdated Show resolved Hide resolved
Analytics-API/MQTT.md Outdated Show resolved Hide resolved
Analytics-API/MQTT.md Outdated Show resolved Hide resolved
Analytics-API/MQTT.md Outdated Show resolved Hide resolved
Analytics-API/MQTT.md Outdated Show resolved Hide resolved
Analytics-API/MQTT.md Outdated Show resolved Hide resolved
Analytics-API/MQTT.md Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Dec 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/placeos/docs/CfekUQrb5Affp3WtLMtAgkGA8uon
✅ Preview: https://docs-git-mqtt-integration-placeos.vercel.app

@mghill
Copy link
Contributor Author

mghill commented Jan 6, 2021

added the <abbr> tags as discussed above, as well as a test of image hosting, and a proof of concept of Mermaid.js but it's very janky there because it was written in their online editor and then embedded remotely rather than written inline as intended. With that caveat though, it works pretty well.

@mghill
Copy link
Contributor Author

mghill commented Apr 22, 2021

As I see it this is currently soft blocked by 2 things.

  1. Sidebar categories issue Sidebar Customisation docs-site#20
    i) this should go in Overview, in a subfolder for something like protocols but I'm not clear on what our current stance is on that. It could go in plain for now, but that starts getting cluttered and it is usually better to sort tooling first
  2. Mermaid.js integration Add support for diagram rendering docs-site#14
    i) I don't know if this is "down the track" enough that we should just use the preexisting static image at the top. There is a proof of concept Mermaid there currently (though it doesn't look great, and isn't actually generated inline - this one is in their online editor)

Provide updates implemented via #84 to enable preview ahead of merge.
@mghill mghill merged commit 6c3c0b9 into main May 28, 2021
@mghill mghill deleted the MQTT-integration branch May 28, 2021 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT Docs
2 participants