Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firebase): add firebase auth #14

Merged
merged 11 commits into from
Jun 3, 2022
Merged

feat(firebase): add firebase auth #14

merged 11 commits into from
Jun 3, 2022

Conversation

chillfox
Copy link
Contributor

Description of the change

Adds methods for working with Firebase Auth.

@chillfox chillfox self-assigned this May 30, 2022
@chillfox chillfox added the type: enhancement new feature or request label May 30, 2022
@chillfox chillfox marked this pull request as ready for review June 2, 2022 04:44
@chillfox chillfox requested review from stakach and caspiano June 2, 2022 04:44
caspiano
caspiano suggested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@caspiano caspiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear, well-written, and good tests!
Made some small comments regarding the data models.

src/firebase/user/lookup_user_response.cr Outdated Show resolved Hide resolved
src/firebase/user/user.cr Outdated Show resolved Hide resolved
src/firebase/user/query_user_response.cr Outdated Show resolved Hide resolved
src/firebase/user/delete_user_response.cr Outdated Show resolved Hide resolved
src/firebase/user/batch_user_response.cr Outdated Show resolved Hide resolved
src/firebase/firebase_auth.cr Outdated Show resolved Hide resolved
@chillfox @caspiano
refactor(firebase): change users to a getter
6c769ae 
Co-authored-by: Caspian Baska <email@caspian.computer>
chillfox and others added 2 commits June 3, 2022 11:14
@chillfox
Copy link
Contributor Author

chillfox commented Jun 3, 2022

@caspiano I have added converters for the time fields (Firebase uses 3 different time formats in the same object)

chillfox and others added 3 commits June 3, 2022 11:32
@chillfox @caspiano
refactor(firebase): change int64 converter to a generic converter
f4bffb6 
Co-authored-by: Caspian Baska <email@caspian.computer>
@chillfox @caspiano
refactor(firebase): prettyfy switch case
163180e 
Co-authored-by: Caspian Baska <email@caspian.computer>
@chillfox
refactor(firebase): use generic converter
d6fe736
caspiano
caspiano reviewed Jun 3, 2022
View reviewed changes
src/auth/auth_helper.cr Outdated Show resolved Hide resolved
@chillfox chillfox merged commit f40fb96 into master Jun 3, 2022
@chillfox chillfox deleted the feat/firebase branch June 3, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspiano caspiano caspiano approved these changes

@stakach stakach Awaiting requested review from stakach

Assignees

@chillfox chillfox

Labels
type: enhancement new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chillfox @caspiano