Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PlaceholderExpansion may not unregistered #793

Merged
merged 2 commits into from Jul 1, 2022
Merged

Fix PlaceholderExpansion may not unregistered #793

merged 2 commits into from Jul 1, 2022

Conversation

Rothes
Copy link
Contributor

@Rothes Rothes commented Jan 28, 2022 •
edited

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

Fix PlaceholderExpansion may not unregistered if Identifier has uppercase letters.

@Andre601 Andre601 added Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Bugfix This fixes an existing bug in PlaceholderAPI. labels Mar 26, 2022
@Rothes Rothes requested a review from Andre601 March 26, 2022 01:10
@darbyjack darbyjack merged commit 5a4a8c2 into PlaceholderAPI:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andre601 Andre601 Andre601 approved these changes

@PiggyPiglet PiggyPiglet PiggyPiglet approved these changes

@darbyjack darbyjack darbyjack approved these changes

@extendedclip extendedclip Awaiting requested review from extendedclip

Assignees
No one assigned
Labels
Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Bugfix This fixes an existing bug in PlaceholderAPI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rothes @Andre601 @PiggyPiglet @darbyjack