Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch all expansions #952

Merged
merged 3 commits into from
Jun 21, 2023
Merged

feat: fetch all expansions #952

merged 3 commits into from
Jun 21, 2023

Conversation

iGabyTM
Copy link
Member

@iGabyTM iGabyTM commented Apr 5, 2023

Fetch all expansions and display a different message if the expansion that the player is trying to download is not verified and cloud_allow_unverified_expansions is false

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

Closes N/A

and display a different message if the expansion that the player is trying to download is not verified and `cloud_allow_unverified_expansions` is false
@iGabyTM iGabyTM added Type: Enhancement New feature or request Target: Code This issue/PR is targeting the Code of PlaceholderAPI labels Apr 5, 2023
@Funny-cube
Copy link
Member

Suggest using https://placeholderapi.com/ecloud as the url so we can redirect if needed in the future

@iGabyTM
Copy link
Member Author

iGabyTM commented Apr 22, 2023

Suggest using placeholderapi.com/ecloud as the url so we can redirect if needed in the future

Looks like the redirect is not setup right, /javascript redirects to https://api.extendedclip.com/home//javascript - notice the double /

@iGabyTM iGabyTM requested a review from Funny-cube June 20, 2023 15:41
@iGabyTM iGabyTM merged commit f91b4e3 into master Jun 21, 2023
@iGabyTM iGabyTM deleted the feature/fetch-all-expansions branch June 21, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants