Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: distinguish expansions (external or internal) (fixes #945) #953

Merged
merged 4 commits into from
Jul 24, 2023
Merged

feat: distinguish expansions (external or internal) (fixes #945) #953

merged 4 commits into from
Jul 24, 2023

Conversation

iGabyTM
Copy link
Member

@iGabyTM iGabyTM commented Apr 5, 2023

external: located in the expansions folder
internal: registered by a plugin

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

Closes N/A

@iGabyTM
feat: distinguish expansions (external or internal) (fixes #945)
2d86870 
external: located in the `expansions` folder
internal: registered by a plugin
@iGabyTM iGabyTM added Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Bugfix This fixes an existing bug in PlaceholderAPI. labels Apr 5, 2023
@iGabyTM iGabyTM requested a review from Starmism April 5, 2023 15:30
@Starmism Starmism linked an issue Apr 5, 2023 that may be closed by this pull request
Consider alternative solution for #864 #945
Closed
4 tasks
@Andre601
Copy link
Collaborator

Andre601 commented Apr 8, 2023 •
edited

Would it be possible to expose the boolean in some way for internal use?

It would allow us to check if the expansion is internal or external for stuff like checking for Updates on the ecloud (Avoiding false positives)

Or we could expose it publicly as a getter somehow (isLocalExpansion()/isCloudExpansion()), tho, not sure if that wouldn't allow others to manipulate PAPI in some way...

@Andre601
Copy link
Collaborator

Andre601 commented Apr 8, 2023 •
edited

Line 304 in LocalExpansionManager should have a && isExternalExpansion added to avoid checking for updates with a local expansion.

@iGabyTM
feat: add expansion type to PlaceholderExpansion
7e7646e
@iGabyTM
feat: disable eCloud check for internal expansions
4a32f59 
If an internal expansion has the same identifier as an expansion that's published to the eCloud, PAPI will always show that an update is available.
@iGabyTM
Copy link
Member Author

iGabyTM commented Jul 8, 2023

Line 304 in LocalExpansionManager should have a && isExternalExpansion added to avoid checking for updates with a local expansion.

Done

@iGabyTM iGabyTM requested a review from Andre601 July 8, 2023 22:30
@iGabyTM iGabyTM merged commit 36fa9ac into master Jul 24, 2023
@iGabyTM iGabyTM deleted the feature/distinguish-expansions branch July 24, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andre601 Andre601 Andre601 approved these changes

@PiggyPiglet PiggyPiglet PiggyPiglet approved these changes

@Starmism Starmism Starmism approved these changes

@BlitzOffline BlitzOffline BlitzOffline approved these changes

@darbyjack darbyjack Awaiting requested review from darbyjack darbyjack is a code owner

Assignees
No one assigned
Labels
Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Bugfix This fixes an existing bug in PlaceholderAPI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider alternative solution for #864
5 participants
@iGabyTM @Andre601 @PiggyPiglet @Starmism @BlitzOffline