Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placekey_format_is_valid() function for invalid placekey #18

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

medhatgayed
Copy link
Contributor

placekey_format_is_valid() function throws a ValueError when a bad placekey contains multiple @ symbols

This MR fixes that issue.

Copy link
Collaborator

@rmtrmt rmtrmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one request for the test case.

placekey/tests/test_placekey.py Outdated Show resolved Hide resolved
@medhatgayed
Copy link
Contributor Author

@rmtrmt It looks like the build is failing because it is expecting PLACEKEY_API_KEY environment variable. Is this something I need to do on my branch? Thanks for your help.

@rmtrmt
Copy link
Collaborator

rmtrmt commented Nov 7, 2022

@rmtrmt It looks like the build is failing because it is expecting PLACEKEY_API_KEY environment variable. Is this something I need to do on my branch? Thanks for your help.

We have PLACEKEY_API_KEY set as a secret for the repository, but pull requests from forks can't run actions with the repository's secretes. If you have an API key, I think you can add it as a secret to your fork and the actions will work. If you don't have an API key, let me know and we can work something else out.

@medhatgayed
Copy link
Contributor Author

@rmtrmt It looks like the build is failing because it is expecting PLACEKEY_API_KEY environment variable. Is this something I need to do on my branch? Thanks for your help.

We have PLACEKEY_API_KEY set as a secret for the repository, but pull requests from forks can't run actions with the repository's secretes. If you have an API key, I think you can add it as a secret to your fork and the actions will work. If you don't have an API key, let me know and we can work something else out.

@rmtrmt I added a PLACEKEY_API_KEY to my fork repository secrets, I was not able to re-run the failed jobs because someone must have write access to the repo to re-run. Do you mind re-running the failed jobs, please?

@rmtrmt
Copy link
Collaborator

rmtrmt commented Nov 17, 2022

The jobs are still failing due to key access. I'll make sure they pass from a copy of this PR from within the repo, and if they do I'll merge this PR.

@rmtrmt rmtrmt merged commit fa48f29 into Placekey:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants