Skip to content

Commit

Permalink
Post-release bugfixes: Batch 2
Browse files Browse the repository at this point in the history
This commit fixes the following bugs:

- Viewing the Town Map in Viridian Pre-Gym would show the player as being in Cerulean.

- Psychic, Psywave, Night Shade and Dazzling Gleam wouldn't shake the full screen

- Okay, NOW it's impossible to trap yourself in Cinnabar Volcano.

- Getting the Vermilion Beauty gift would lock you out from getting the Silph Co Lapras gift later.

- Text fixes
  • Loading branch information
MementoMartha committed Jan 12, 2024
1 parent 3e3b895 commit 0c65063
Show file tree
Hide file tree
Showing 12 changed files with 37 additions and 50 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ and more!

Known Bugs
====
- Occasionally, saving and reloading in a building will cause the border tile to completely change, in some cases letting you walk out of bounds.
- Trying to Surf from the overworld on Cycling Road has an invisible textbox stopping you, but just pressing A again lets you regain control.
- Jumping from a specific tile off a ledge in Cerulean City causes you to land on a fence. This is being kept in, because it's funny.

Expand Down
2 changes: 1 addition & 1 deletion data/events/trades.asm
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ TradeMons:
db SANDSLASH, SANDSLASH_A, TRADE_DIALOGSET_REGION, "SANDSLASH@@" ; Celadon
db RAICHU, RAICHU_A, TRADE_DIALOGSET_REGION, "RAICHU@@@@@" ; Saffron
db MAROWAK, MAROWAK_A, TRADE_DIALOGSET_REGION, "MAROWAK@@@@" ; Fuschia
db MUK, MUK_A, TRADE_DIALOGSET_REGION, "MUK-A@@@@@@" ; Cinnabar
db MUK, MUK_A, TRADE_DIALOGSET_REGION, "MUK@@@@@@@@" ; Cinnabar
db EXEGGUTOR, EXEGGUTOR_A, TRADE_DIALOGSET_REGION, "EXEGGUTOR@@" ; Indigo
db TAUROS, TAUROS_P, TRADE_DIALOGSET_TAUROSC, "TAUROS@@@@@" ; S.S. Anne begins here
db TAUROS, TAUROS_PA, TRADE_DIALOGSET_TAUROSA, "TAUROS@@@@@"
Expand Down
2 changes: 1 addition & 1 deletion data/maps/town_map_entries.asm
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ InternalMapEntries:
internal_map MT_MOON_B2F, 6, 2, MountMoonName
internal_map CERULEAN_MART, 10, 2, CeruleanCityName
internal_map MT_MOON_POKECENTER, 5, 2, Route4Name
internal_map VIRIDIAN_PRE_GYM, 10, 2, ViridianCityName
internal_map VIRIDIAN_PRE_GYM, 2, 8, ViridianCityName
internal_map DAYCARE, 10, 4, Route5Name
internal_map UNDERGROUND_PATH_ROUTE_6, 10, 8, Route6Name
internal_map CELESTE_HILL, 7, 9, CelesteHillName
Expand Down
6 changes: 3 additions & 3 deletions engine/battle/animations.asm
Original file line number Diff line number Diff line change
Expand Up @@ -1861,8 +1861,8 @@ AnimationWavyScreen:
ld c, $ff
ld hl, WavyScreenLineOffsets
.loop
; ld a, [hl] ; this fixes the wavy screen, but causes a bank overflow
; ldh [hSCX], a
ld a, [hl] ; this fixes the wavy screen, but causes a bank overflow
ldh [hSCX], a
push hl
.innerLoop
call WavyScreen_SetSCX
Expand All @@ -1879,7 +1879,7 @@ AnimationWavyScreen:
dec c
jr nz, .loop
xor a
; ldh [hSCX], a ; also fixing the wavy screen
ldh [hSCX], a ; also fixing the wavy screen
ldh [hWY], a
call SaveScreenTilesToBuffer2
call ClearScreen
Expand Down
2 changes: 1 addition & 1 deletion maps/CinnabarVolcano.blk
Original file line number Diff line number Diff line change
@@ -1 +1 @@
..............}vvvvvvvvvvvv}Qvvvvvvvvv}vvvvvvvvvvvvvvv45vvvvvvvv+67,vvvv8-%88vvNvvvvv vvvvR}vvvv vvv}N}vvv>vv}}}}Q}}}}}}QN
..............}vvvvvvvvvvvv}Qvvvvvvvvv}vvvvvv3vvvvvvvvv45vvvvvvvv+67,vvvv8-%88vvNvvvvv vvvvR}vvvv vvv}N}vvv>vv}}}}Q}}}}}}QN
5 changes: 2 additions & 3 deletions scripts/BattleTent.asm
Original file line number Diff line number Diff line change
Expand Up @@ -820,13 +820,12 @@ BattleTentLetsGo:
done
BattleTentWon:
text "Wow! You finally"
line "did it!"
text "Congratulations!"
para "You beat"
line "@"
text_decimal wBTStreakCnt, 1, 3
text " oppenont(s)!"
text " opponent(s)!"
prompt
BattleTentLost:
Expand Down
8 changes: 4 additions & 4 deletions scripts/SilphCo7F.asm
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ SilphCo7TrainerHeader3:
SilphCo7Text1:
; lapras guy
text_asm
ld a, [wd72e]
bit 0, a ; got lapras?
ld a, [wd72c]
bit 2, a
jr z, .givelapras
CheckEvent EVENT_BEAT_SILPH_CO_GIOVANNI
jr nz, .savedsilph
Expand All @@ -329,8 +329,8 @@ SilphCo7Text1:
call EnableAutoTextBoxDrawing
ld hl, .HeresYourLaprasText
call PrintText
ld hl, wd72e
set 0, [hl]
ld hl, wd72c
set 2, [hl]
jr .done
.savedsilph
ld hl, .LaprasGuySavedText
Expand Down
45 changes: 17 additions & 28 deletions text/CeruleanBadgeHouse.asm
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ _CeruleanHouse2Text_74e77::
line "are owned only by"
cont "skilled trainers."

para "I see you have"
line "at least one."

para "Those BADGEs have"
line "amazing secrets!"
prompt
Expand Down Expand Up @@ -34,15 +31,9 @@ _CeruleanHouse2Text_74e96::
prompt

_CeruleanHouse2Text_74e9b::
text "#MON up to L30"
line "will obey you."

para "Any higher, they"
line "become unruly!"

para "It also lets you"
line "use CUT outside"
cont "of battle."
text "It lets you use"
line "CUT outside of"
cont "battle."
prompt

_CeruleanHouse2Text_74ea0::
Expand All @@ -56,15 +47,9 @@ _CeruleanHouse2Text_74ea0::
prompt

_CeruleanHouse2Text_74ea5::
text "#MON up to L50"
line "will obey you."

para "Any higher, they"
line "become unruly!"

para "It also lets you"
line "use STRENGTH out-"
cont "side of battle."
text "It lets you use"
line "STRENGTH outside"
cont "of battle."
prompt

_CeruleanHouse2Text_74eaa::
Expand All @@ -78,11 +63,14 @@ _CeruleanHouse2Text_74eaa::
prompt

_CeruleanHouse2Text_74eaf::
text "#MON up to L70"
line "will obey you."

para "Any higher, they"
line "become unruly!"
text "Hmm... I can't"
line "remember."

para "Should you beat"
line "SABRINA's tough"
cont "PSYCHIC #MON,"
cont "she may tell"
cont "you."
prompt

_CeruleanHouse2Text_74eb4::
Expand All @@ -92,6 +80,7 @@ _CeruleanHouse2Text_74eb4::
prompt

_CeruleanHouse2Text_74eb9::
text "All #MON will"
line "obey you!"
text "You'll be able to"
line "challenge the"
cont "#MON LEAGUE!"
prompt
2 changes: 1 addition & 1 deletion text/CitrineCity.asm
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ _CitrineCityCavern::

_CitrineCityDirections::
text "NORTH WEST:"
line "BATTLE TOWER"
line "BATTLE TENT"
para "NORTH EAST:"
line "CELESTE HILL"
Expand Down
2 changes: 1 addition & 1 deletion text/Daycare_2.asm
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ _DayCareAllRightThenText::
text_end

_DayCareComeAgainText::
text "come again."
text "Come again."
done

_DayCareNoRoomForMonText::
Expand Down
2 changes: 1 addition & 1 deletion text/ViridianPreGym.asm
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ _BeforeReceivedBottleCapText::
para "I won't give up!"
line "I'll train with"
cont "my POKEMON until"
cont "my #MON until"
cont "we're the best"
cont "there is!"
Expand Down
10 changes: 5 additions & 5 deletions text/pokedex_ratings.asm
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ _DexRatingText_Own50To64::
done

_DexRatingText_Own65To79::
text "Ho! This is geting"
text "This is getting"
line "even better!"
done

Expand All @@ -53,8 +53,8 @@ _DexRatingText_Own80To99::
done

_DexRatingText_Own100To114::
text "You finally got at"
line "least 100 species!"
text "You've finally got"
line "over 100 species!"
cont "Great job!"
done

Expand Down Expand Up @@ -90,8 +90,8 @@ _DexRatingText_Own180To199::
done

_DexRatingText_Own200To214::
text "You finally got at"
line "least 200 species!"
text "You finally passed"
line "200 species!"
cont "I can't believe"
cont "how good you are!"
done
Expand Down

0 comments on commit 0c65063

Please sign in to comment.