Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolled-up into footnotes require entry to have a body #316

Closed
fluffy-critter opened this issue Nov 28, 2019 · 0 comments · Fixed by #317
Closed

Rolled-up into footnotes require entry to have a body #316

fluffy-critter opened this issue Nov 28, 2019 · 0 comments · Fixed by #317
Labels
bug Something isn't working markdown Functionality involving the Markdown processor

Comments

@fluffy-critter
Copy link
Collaborator

fluffy-critter commented Nov 28, 2019

Expected Behavior

{{entry.more}} should always render the entry's footnotes if there are any to render, even if there's no more-text or no footnotes.

Current Behavior

If nothing triggers the markdown renderer's footnote section, they don't get rendered. Oops.

Possible Solution

Move the footnote buffer flush stuff outside of the markdown renderer.

Steps to Reproduce (for bugs)

Two test cases:

Title: Footnotes in intro, no more-text

This is text.[^fn]

[^fn]: This is a footnote.
Title: Footnotes in intro, more-text with no footnotes

This is text.[^fn]

[^fn]: This is a footnote.

.....

This is more-text.

Context

@fluffy-critter fluffy-critter added bug Something isn't working markdown Functionality involving the Markdown processor labels Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working markdown Functionality involving the Markdown processor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant