Support entry and image links in plain-HTML entries #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffy-critter
added a commit
that referenced
this pull request
Mar 4, 2019
Support entry and image links in plain-HTML entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supports rewriting link and image targets in HTML entries; fixes #136 and #154.
Detailed description
This adds a simple HTML transform step which scans all elements for
hrefandsrclinks, and rewrites their targets appropriately. In the case of<img>tags it also uses thewidthandheightattributes in addition to the template configuration to select the appropriate renditions.Developer/user impact
Adds a lot of functionality to HTML entries, but also changes the Image API somewhat. See PlaidWeb/publ-site@baaea3b for related documentation changes.
Test plan
Added tests in PlaidWeb/publ-site@baaea3b