Support linking to non-image asset files #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffy-critter
added a commit
that referenced
this pull request
Mar 4, 2019
Support linking to non-image asset files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows the use of assets that PIL doesn't support in both image and link contexts. Fixes #141.
Detailed description
If we try to resolve an image or a link to a file which isn't supported by PIL, the file gets indexed as an asset instead. If a file is indexed as an asset then it becomes retrievable via a URL like
_file/<shorthash>/<basename>, which simply sends the file directly if it's been indexed as an asset.This also ends up refactoring a lot of link handling stuff and makes for fewer weird paths things can go through. There are still a couple of places where
utils.remap_link_targetare called, but these can probably be refactored away in the future.Developer/user impact
Test plan
Added a bunch of tests to publ-site; see PlaidWeb/publ-site@66b7a04