Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle source redirection #35

Closed
fluffy-critter opened this issue Dec 2, 2019 · 1 comment · Fixed by #36
Closed

Handle source redirection #35

fluffy-critter opened this issue Dec 2, 2019 · 1 comment · Fixed by #36

Comments

@fluffy-critter
Copy link
Contributor

If an entry URL changes, Pushl should re-send all of its mentions from the old URL so the endpoint knows to update them.

This can happen in Pushl.process_entry, by looking to see if url != entry.url and making the target set entry.get_targets(self) | previous.get_targets(self). Then the API for Pushl.process_entry changes to be the entry url instead of the entry object, and it sends based on the original URL rather than the resolved one.
@fluffy-critter
Copy link
Contributor Author

Closed in #36

This was referenced Dec 2, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle entry location changes PlaidWeb/Pushl
1 participant
@fluffy-critter