Handle entry location changes #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #212 This handles both the case of a shortlink -> permalink redirection changing (i.e. feed URL doesn't change but resolved URL does), and a permalink redirection (i.e. old URL disappears from feed, and the deletion detection sees that it just changed locations instead). In both cases it re-sends all of the webmentions from the old URL to its targets, and it's up to the webmention endpoint to chase the redirections when it verifies the mentions. Tested by running a Publ site on localhost; created an entry with outgoing links to example.com URLs, pung from the feed, changed the entry's URL and added a link, pung from the feed again, then did the same but pinging with `-e` to the entry's shortlink.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
This handles both the case of a shortlink -> permalink redirection changing (i.e. feed URL doesn't change but resolved URL does), and a permalink redirection (i.e. old URL disappears from feed, and the deletion detection sees that it just changed locations instead). In both cases it re-sends all of the webmentions from the old URL to its targets, and it's up to the webmention endpoint to chase the redirections when it verifies the mentions.
Also ended up refactoring the webmention code a bit to reduce the
process_entrycomplexity and to deduplicate the pending task await code.Tested by running a Publ site on localhost; created an entry with outgoing links to example.com URLs, pung from the feed, changed the entry's URL and added a link, pung from the feed again, then did the same but pinging with
-eto the entry's shortlink.