Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parsing of file names more robust #8

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Make parsing of file names more robust #8

merged 5 commits into from
Oct 24, 2023

Conversation

korya
Copy link
Member

@korya korya commented Oct 24, 2023

Try to make the logic for parsing strings (and file names) from TAR headers more robust:

  • explicitly set the encoding to UTF-8 (utf8)
  • parse and slice using Buffer's toString() method; that is, pass it the offset to be printed
  • trim 0 bytes only at the end of the string
  • log the parsed file name

gitstream-cm[bot]
gitstream-cm bot previously requested changes Oct 24, 2023
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

adamdupuis
adamdupuis previously approved these changes Oct 24, 2023
gitstream-cm[bot]
gitstream-cm bot previously requested changes Oct 24, 2023
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

@gitstream-cm gitstream-cm bot dismissed their stale review October 24, 2023 18:27

Review resolved

Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

gitstream-cm[bot]
gitstream-cm bot previously requested changes Oct 24, 2023
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

@gitstream-cm gitstream-cm bot dismissed their stale review October 24, 2023 19:16

Review resolved

gitstream-cm[bot]
gitstream-cm bot previously requested changes Oct 24, 2023
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

@gitstream-cm gitstream-cm bot dismissed their stale review October 24, 2023 19:17

Review resolved

Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

@gitstream-cm gitstream-cm bot dismissed their stale review October 24, 2023 19:21

Review resolved

@korya korya merged commit c913bac into master Oct 24, 2023
4 of 6 checks passed
@korya korya deleted the support-buffer branch October 24, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants