Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of default flowcell type into Fluidic Acquisition page #439

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

ethanjli
Copy link
Member

This PR fixes a bug where the acq_celltype field in the config.json file was not correctly used to set the default-selected flowcell in the Node-RED dashboard's "Fluidic Acquisition" page. This PR also removes the "Dashboard Errors" panel from the "Administration" page (implementing a change requested & approved in the 2024-06-20 software meeting) since that panel has never displayed any useful error messages in the past ~8 months of testing with v2023.9.0 and v2024.0.0

@ethanjli
Copy link
Member Author

I've tested these changes, so I'll merge this PR when CI checks pass.

@ethanjli ethanjli added this pull request to the merge queue Jun 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 22, 2024
@ethanjli ethanjli added this pull request to the merge queue Jun 22, 2024
Merged via the queue into master with commit bed6a25 Jun 22, 2024
9 checks passed
@ethanjli ethanjli deleted the fix/nodered-dashboard-flowcell branch June 22, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant