Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New movie player in the analysis panel that downloads a zipfile of all JPEGs #423

Merged
merged 43 commits into from
Jun 16, 2024

Conversation

simsong
Copy link
Member

@simsong simsong commented Jun 11, 2024

Closes #404
Closes #414
Closes #403
Closes #401
Closes #386
Closes #364
Closes #326
Closes #371

Progress on #141

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 87.28324% with 22 lines in your changes missing coverage. Please review.

Project coverage is 84.44%. Comparing base (19dfdb4) to head (ee3a033).

Files Patch % Lines
db.py 81.81% 8 Missing ⚠️
tracker.py 80.76% 5 Missing ⚠️
bottle_api.py 91.66% 4 Missing ⚠️
db_object.py 57.14% 3 Missing ⚠️
bottle_app.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   84.30%   84.44%   +0.14%     
==========================================
  Files          23       23              
  Lines        2637     2720      +83     
==========================================
+ Hits         2223     2297      +74     
- Misses        414      423       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* zipfile movie download
* zipfile movie display
* No longer storing frames in object store when tracking
* changed 'trackpoints' to 'markers' in many locations (but not in database or throughout the API).
@simsong
Copy link
Member Author

simsong commented Jun 15, 2024

This seems to now work!
image

@simsong simsong marked this pull request as ready for review June 15, 2024 10:53
@simsong simsong added enhancement New feature or request high priority UX labels Jun 15, 2024
@simsong
Copy link
Member Author

simsong commented Jun 15, 2024

@joedinsmoor and @sbarber2 — My plan is to merge this into main after I have this running on dev.

@simsong
Copy link
Member Author

simsong commented Jun 16, 2024

Sorry, @snyk-bot , I'm accepting this PR.

@simsong simsong merged commit 6060486 into main Jun 16, 2024
6 of 7 checks passed
@simsong simsong deleted the dev-movieapi branch June 16, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants