-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'part of' relation and associated logic #61
Comments
Thanks for that, @ramonawalls . I have 4 comment on this topic. First, for this discussion, it is important to remember that the methodology we are using to go from data about a Second, to the immediate question of whether we can use the existing
Third, we should keep in mind that given our current data model, Fourth, I've been thinking about an extension to our logical model that might be another way to address some of these concerns. What if we added a way to record the proportion of a |
Thanks for putting this here, @stuckyb. I will respond to your four points. Please bear in mind that I am in large part conveying the arguments of others, and until I have done some playing with this in Protege and the pipeline, I am not certain what the best solutions is. Also remember that the people giving advice are less familiar with our project than us, but have done a ton of similar work.
Regarding you concerns, the suggestion was not to use reflexive part of, but to use the current RO which is neither reflexive nor irreflexive (so when reasoning, it won't through an error for either type of instance). While I fully appreciate the requirement to keep axiomatization and minimal as possible, the argument was that using a proper_part_of relation would not actually work. We aren't interested in all proper parts of a whole plant, rather only in parts of a plant in which a significant portion of the plant is missing. I think for most of our traits, the minimal part that would need to be missing for us to not be able to infer absence on the whole plant is a shoot system (shoots system includes branches, flowers, and buds). Maybe it would need to be missing only a leaf, for leaf traits. We might create a relation that is called proper_part_of and define it to mean what I just described, but I was pretty convinced by Chris that a true proper part of relation is meaningless in many cases. That said, I can imagine that there might be a way to make it work.
Along these lines, I'm not sure why we need to have a single relation that covers both cases, since we would normally know if something is part of or was part of. I guess it makes the ingest pipeline easier to not have to deal with two separate types of data, but I'm not sure how much.
On the other hand, I think this corresponds in part to the definition discussed in point 2, which was that we define portion of plant based on what is missing from the plant, rather than just saying anything is missing. |
Thanks, Ramona. Interesting points for sure. I am thoroughly convinced of at least one thing -- there are no obviously correct answers here. One quick comment, though -- as I see it, the existing RO |
A point of clarification here regarding using |
We discussed this at our workshop, and we don't see any need to change it at this time. See also the decision about scoring parts of plants in issue #68. |
I'm creating this issue to document ongoing discussions about how we connect a 'portion of a plant' to a 'whole plant' and the logical inferences implied by that connection.
Here is the most recent email on this topic, from @ramonawalls 👍
The text was updated successfully, but these errors were encountered: