Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent pattern for hulled/dehulled grain traits #413

Open
elsadebecker opened this issue Jun 6, 2017 · 0 comments
Open

Inconsistent pattern for hulled/dehulled grain traits #413

elsadebecker opened this issue Jun 6, 2017 · 0 comments

Comments

@elsadebecker
Copy link

elsadebecker commented Jun 6, 2017

There are a number of traits (length, width, etc) where measurements can be made on hulled, dehulled, or polished grains. These are treated inconsistently in the ontology:

For ratio, TO:0002731 grain length to width ratio “A grain size (TO:0000397) which is determined from grain length and grain width on dehulled grain.” is the parent trait, TO:0000375 brown rice ratio “A grain length to width ratio (TO:0002731) which is determined from grain length and grain width on dehulled unpolished rice grain” is the child trait. Also, TO:0000411 seed length to width ratio “Ratio of length to width of the seed or fruit caryopsis with hull.” is a child of seed length

For width, TO:0000402 dehulled grain width “A fruit width (TO:0002627) which is associated with the width of the dehulled grain with pericarp (PO:0009084).” is parent to TO:0002762 width of grain with hull “A grain width (TO:0000402) with hull.”

For length, TO:0000734 grain length “A fruit length (TO:0002626) of the dehulled grain with pericarp (PO:0009084).” is parent to TO:0000041 brown rice length “A grain length (TO:0000734) monitored after dehulling but before polishing. The grain should contain pericarp (PO:0009084).” and TO:0002761 length of grain with hull “A grain length (TO:0000734) with hull.”

For thickness, there is only TO:0000399 grain thickness “Thickness of the dehulled grain with pericarp.”

For volume, TO:0002743 grain volume “A fruit volume (TO:0002742) of a grain without hull (dehulled).” and TO:0002765 volume of grain with hull “Volume of the grain with hull (hulled).” are both children of fruit volume

For surface area, there is only TO:0002741 grain surface area “The average surface area of the grain without hull (dehulled) in a grass fruit caryopsis.”

For shape, TO:0002730 grain shape “A fruit shape (TO:0002628) which is associated with the variation in the shape of the dehulled grain.” is parent to TO:0000287 brown rice shape “A grain shape (TO:0002730) of the brown rice. Measure after harvesting, cleaning, and dehulling.”

To me, it makes sense to follow the pattern used for volume, where hulled and dehulled traits are both children of some other trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant