This repository has been archived by the owner on Oct 5, 2021. It is now read-only.
Fix/32 codehash #43
Merged
Fix/32 codehash #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoonsubin
suggested changes
Jul 5, 2021
4 tasks
hoonsubin
suggested changes
Jul 6, 2021
* Resolve not render contracts properly * Fix issue which signer is not changed * Add contract items * bind data on render list * fix lint * Feature/contract info (#28) * set icon based on alerttype * Add abi hooks for contract * deplying ing... * Add accountsigner * get successful to deploying contracts * set loading while deploying contract * Add store module for contract * Finished add contract from existing hash * fix linting * change npm module version * resolve contract-util issue * remove rpc * update pull request actions (#25) * update pull request actions * change step names * add engine config to package.json * remove metadata test josn * fix file upload issue * refactors * working well before refactor * get rid of api store things * remove boilerplate apipromise on hook * Update plasm-types version > 1.5.4-2 * refactor params helper * Feature/switch mode (#26) * edit tailwind.config * implement switching modes locally * tweak styles * use vuex to store theme * working on contract-info ui * implemnt contract info ui * modifty modal and message to include msgs docs * implement tooltip for contract messages * modify message type in modal * move message into contract-info * add forget btn on code hashes * bind with confirm-removal-modal && refactors Co-authored-by: Will Park <korea651@hanmail.net> Co-authored-by: Hoon Kim <mail@hoonkim.me> Co-authored-by: Hoon Kim <40356749+hoonsubin@users.noreply.github.com> * add helper in param, add index field to MessageType * implement constructor selector UI * rename params to paramsgen * use paramsGen in modal, add navigations, improve UX * fix styles * add balance component * use balance component in formatbalance * add inputBalance component * use inputbalance in modaltransfer * fix modal ui, log params * add input for number and boolean * add deploy workflow (#41) * add public path config (#42) * modify inputbalance compoennt * twak inputbalance ui * made inputbalance to emit new event * implment param gen for primitive types * made ParamGeneator take params and index Co-authored-by: Will Park <korea651@hanmail.net> Co-authored-by: Hoon Kim <mail@hoonkim.me> Co-authored-by: Hoon Kim <40356749+hoonsubin@users.noreply.github.com>
Closed
|
Fixed above drop zone issue and created new issue regarding endowment estimation - #45 |
|
also, it includes adding shiden network |
hoonsubin
suggested changes
Jul 9, 2021
There was a problem hiding this comment.
Unfortunately, I am still seeing the same issue regarding the contract deployment. As you mentioned, I think moving that to a separate issue better and skip that for this PR.
However, there are issues with Shiden network type registry that prevents it from displaying account balance data. After we can fix the balance display issue, I think we can call it done for now (unless there are other improvements we can make quickly).
hoonsubin
suggested changes
Jul 12, 2021
hoonsubin
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues in #32
change the balance input component format for Endowment (UNIT) and Max gas allowed so that it matches the style of ones in the Transfer modal. The input box should allow the users to choose a different token metric or use decimal strings
allow the user to upload the metadata.json file instead of pasting the full JSON string when adding a contract code hash and switch the location for the bundle name and code hash input box